refactor: return errors with stack traces, where appropriate
1 file changed, 5 insertions(+), 2 deletions(-)
changed files
M internal/vcs/filelog.go → internal/vcs/filelog.go
@@ -31,8 +31,10 @@ return u } -func (r *Repository) GetFileLog(filename string) (cs []*Commit, err error) { - fl, err := r.repo.Log(&git.LogOptions{ +func (r *Repository) GetFileLog(filename string) ([]*Commit, errors.E) { + var fl object.CommitIter + var err error + fl, err = r.repo.Log(&git.LogOptions{ Order: git.LogOrderCommitterTime, FileName: &filename, })@@ -41,6 +43,7 @@ return nil, errors.WithMessagef(err, "could not get git log for file %s", filename) } defer fl.Close() + cs := make([]*Commit, 0) err = fl.ForEach(func(c *object.Commit) error { cs = append(cs, &Commit{ Hash: c.Hash.String(),