all repos — elgit @ f41c7baefd86bf8db0e5f096c449997d9427f813

fork of legit: web frontend for git, written in go

configure golangci-lint

Alan Pearce
commit

f41c7baefd86bf8db0e5f096c449997d9427f813

parent

721a55a5b5ab180d4828e8de8175b24ca8d244f3

1 file changed, 11 insertions(+), 0 deletions(-)

changed files
M git/service/service.gogit/service/service.go
@@ -35,22 +35,26 @@ cmd.Stderr = cmd.Stdout
if err := cmd.Start(); err != nil { log.Printf("git: failed to start git-upload-pack (info/refs): %s", err) + return err } if err := packLine(c.Stdout, "# service=git-upload-pack\n"); err != nil { log.Printf("git: failed to write pack line: %s", err) + return err } if err := packFlush(c.Stdout); err != nil { log.Printf("git: failed to flush pack: %s", err) + return err } buf := bytes.Buffer{} if _, err := io.Copy(&buf, stdoutPipe); err != nil { log.Printf("git: failed to copy stdout to tmp buffer: %s", err) + return err }
@@ -58,6 +62,7 @@ if err := cmd.Wait(); err != nil {
out := strings.Builder{} _, _ = io.Copy(&out, &buf) log.Printf("git: failed to run git-upload-pack; err: %s; output: %s", err, out.String()) + return err }
@@ -100,20 +105,24 @@ }()
if err := cmd.Start(); err != nil { log.Printf("git: failed to start git-upload-pack: %s", err) + return err } if _, err := io.Copy(stdinPipe, c.Stdin); err != nil { log.Printf("git: failed to copy stdin: %s", err) + return err } if _, err := io.Copy(newWriteFlusher(c.Stdout), stdoutPipe); err != nil { log.Printf("git: failed to copy stdout: %s", err) + return err } if err := cmd.Wait(); err != nil { log.Printf("git: failed to wait for git-upload-pack: %s", err) + return err }
@@ -122,10 +131,12 @@ }
func packLine(w io.Writer, s string) error { _, err := fmt.Fprintf(w, "%04x%s", len(s)+4, s) + return err } func packFlush(w io.Writer) error { _, err := fmt.Fprint(w, "0000") + return err }