all repos — erl @ c8ab7c849959313a035bf9e448d110e794190a4f

Execute Reload Loop

command/command_test.go (view raw)

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
package command

import (
	"bytes"
	"testing"
	"time"
)

func TestNew(t *testing.T) {
	t.Parallel()

	tests := []struct {
		name     string
		cmdName  string
		args     []string
		expected string
	}{
		{
			name:     "simple command",
			cmdName:  "echo",
			args:     []string{"hello"},
			expected: "echo",
		},
		{
			name:     "command with multiple args",
			cmdName:  "ls",
			args:     []string{"-l", "-a"},
			expected: "ls",
		},
		{
			name:     "command with no args",
			cmdName:  "pwd",
			args:     []string{},
			expected: "pwd",
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()

			var stdout, stderr bytes.Buffer
			cmd := New(tt.cmdName, tt.args, Options{
				Stdout: &stdout,
				Stderr: &stderr,
			})

			if cmd == nil {
				t.Fatal("New() returned nil")
			}

			if cmd.name != tt.expected {
				t.Errorf("expected name %s, got %s", tt.expected, cmd.name)
			}

			if len(cmd.args) != len(tt.args) {
				t.Errorf("expected %d args, got %d", len(tt.args), len(cmd.args))
			}

			for i, arg := range tt.args {
				if i < len(cmd.args) && cmd.args[i] != arg {
					t.Errorf("expected arg[%d] %s, got %s", i, arg, cmd.args[i])
				}
			}
		})
	}
}

func TestStart(t *testing.T) {
	t.Parallel()

	tests := []struct {
		name        string
		cmdName     string
		args        []string
		shouldError bool
	}{
		{
			name:        "valid command",
			cmdName:     "echo",
			args:        []string{"test"},
			shouldError: false,
		},
		{
			name:        "invalid command",
			cmdName:     "nonexistentcommand12345",
			args:        []string{},
			shouldError: true,
		},
		{
			name:        "valid command with args",
			cmdName:     "sleep",
			args:        []string{"0.1"},
			shouldError: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()

			var stdout, stderr bytes.Buffer
			cmd := New(tt.cmdName, tt.args, Options{
				Stdout: &stdout,
				Stderr: &stderr,
			})
			err := cmd.Start()

			if tt.shouldError {
				if err == nil {
					t.Error("expected error but got none")
				}
			} else {
				if err != nil {
					t.Errorf("unexpected error: %v", err)
				}

				if cmd.Cmd == nil {
					t.Error("exec.Cmd should be initialized after Start()")
				}

				if cmd.Process == nil {
					t.Error("Process should be set after successful Start()")
				}
			}
		})
	}
}

func TestWait(t *testing.T) {
	t.Parallel()

	t.Run("wait for successful command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Errorf("unexpected error waiting for command: %v", err)
		}

		if !cmd.Exited() {
			t.Error("command should be marked as exited after Wait()")
		}
	})

	t.Run("wait for failing command", func(t *testing.T) {
		t.Parallel()

		// Use a command that will fail
		var stdout, stderr bytes.Buffer
		cmd := New("ls", []string{"/nonexistent/directory/12345"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Errorf("unexpected error from failing command: %v", err)
		}

		if !cmd.Exited() {
			t.Error("command should be marked as exited after Wait() even on failure")
		}
	})
}

func TestStop(t *testing.T) {
	t.Parallel()

	t.Run("stop running command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("sleep", []string{"10"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		// Give the command a moment to actually start
		time.Sleep(100 * time.Millisecond)

		err = cmd.Stop()
		if err != nil {
			t.Errorf("unexpected error stopping command: %v", err)
		}

		// Wait a bit and check if process is actually killed
		time.Sleep(100 * time.Millisecond)

		// Try to wait for the process - it should return quickly since it was killed
		waitDone := make(chan error, 1)
		go func() {
			waitDone <- cmd.Wait()
		}()

		select {
		case <-waitDone:
			// Good, Wait() returned quickly
		case <-time.After(1 * time.Second):
			t.Error("process was not killed properly - Wait() is still blocking")
		}
	})

	t.Run("stop non-running command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		// Try to stop before starting
		err := cmd.Stop()
		if err != nil {
			t.Errorf("stopping non-running command should not error: %v", err)
		}
	})

	t.Run("stop already finished command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Fatalf("failed to wait for command: %v", err)
		}

		err = cmd.Stop()
		if err != nil {
			t.Errorf("stopping finished command should not error: %v", err)
		}
	})
}

func TestExited(t *testing.T) {
	t.Parallel()

	t.Run("not started command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		if cmd.Exited() {
			t.Error("command that hasn't started should not be marked as exited")
		}
	})

	t.Run("started but not finished command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("sleep", []string{"1"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		if cmd.Exited() {
			t.Error("running command should not be marked as exited")
		}

		// Clean up
		cmd.Stop()
	})

	t.Run("finished command", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Fatalf("failed to wait for command: %v", err)
		}

		if !cmd.Exited() {
			t.Error("finished command should be marked as exited")
		}
	})
}

func TestMultipleStarts(t *testing.T) {
	t.Parallel()

	t.Run("multiple start calls", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		// First start
		err := cmd.Start()
		if err != nil {
			t.Fatalf("first start failed: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Fatalf("wait failed: %v", err)
		}

		// Second start should work (creates new exec.Cmd)
		err = cmd.Start()
		if err != nil {
			t.Errorf("second start failed: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Errorf("second wait failed: %v", err)
		}
	})
}

func TestMakeCommand(t *testing.T) {
	t.Parallel()

	t.Run("makeCommand sets up exec.Cmd correctly", func(t *testing.T) {
		t.Parallel()

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"hello", "world"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		// makeCommand is called internally by Start, so we test it through Start
		err := cmd.Start()
		if err != nil {
			t.Fatalf("failed to start command: %v", err)
		}

		if cmd.Cmd == nil {
			t.Error("exec.Cmd should be initialized")
		}

		if cmd.Stdout != &stdout {
			t.Error("Stdout should be set to the provided buffer")
		}

		if cmd.Stderr != &stderr {
			t.Error("Stderr should be set to the provided buffer")
		}

		cmd.Wait()
	})
}

func TestCommandInterface(t *testing.T) {
	t.Parallel()

	t.Run("Cmd implements Command interface", func(t *testing.T) {
		t.Parallel()

		var _ Command = &Cmd{}

		var stdout, stderr bytes.Buffer
		cmd := New("echo", []string{"test"}, Options{
			Stdout: &stdout,
			Stderr: &stderr,
		})

		// Test that all Command interface methods work
		err := cmd.Start()
		if err != nil {
			t.Fatalf("Start() failed: %v", err)
		}

		err = cmd.Wait()
		if err != nil {
			t.Errorf("Wait() failed: %v", err)
		}

		err = cmd.Stop()
		if err != nil {
			t.Errorf("Stop() failed: %v", err)
		}
	})
}